feat(node-native): Add support for V8 v14 (Node v25+)#20125
feat(node-native): Add support for V8 v14 (Node v25+)#20125
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Core
Deps
Other
Bug Fixes 🐛Deno
Other
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c1769d6. Configure here.
| }, | ||
| "dependencies": { | ||
| "@sentry-internal/node-native-stacktrace": "^0.3.0", | ||
| "@sentry-internal/node-native-stacktrace": "^0.4.0", |
There was a problem hiding this comment.
No integration or E2E test for new feature
Low Severity
This is a feat PR that adds support for V8 v14 (Node v25+) by bumping @sentry-internal/node-native-stacktrace to ^0.4.0, but the PR does not appear to include any integration or E2E test verifying that the new V8 v14 / Node v25+ support actually works. Per the review rules, feat PRs are expected to include at least one integration or E2E test. Adding a test that exercises the event loop block detection on a supported Node version would help catch regressions.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit c1769d6. Configure here.
There was a problem hiding this comment.
@sentry-internal/node-native-stacktrace is already tested in Node v25 and once this is merged and released it will also be tested in Electron v38+
2 participants
This PR updates to the latest release of
@sentry-internal/node-native-stacktracewhich adds supports for V8 v14+ which was added in this PR:ie.